Support 2 chained/stacked 64x32 DMD Led Panels#84
Open
albpara wants to merge 3 commits intojnthas:mainfrom
Open
Support 2 chained/stacked 64x32 DMD Led Panels#84albpara wants to merge 3 commits intojnthas:mainfrom
albpara wants to merge 3 commits intojnthas:mainfrom
Conversation
Owner
|
I can test it here. Just let me know when is ready. Thanks for the PR! |
|
@albpara could this be extended to support multiple chains of 64x64 panels? |
Author
|
I don't see too much sense on that since the clock uses 64x64 resolution. What are you trying to achieve? |
Owner
|
@albpara I see the PR is still in Draft. Let me know what you need to complete it. |
Author
|
Just need a confirmation of my changes working with a single 64x64 panel and I don't have any... is it possible for you to give it a try @jnthas? |
I have an idea for a 128x64 design. Is there a resolution limitation? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
This is a work in progress, do not review yet
After my frustration for not being capable of using my 64x32 panel to build this amazing clock, I decided to give it a try and make the option to chain this panels configurable.
I followed the instructions in Can I chain Panels? from ESP32-HUB75-MatrixPanel-DMA I quickly noticed the following statement:
Basically... if you need more than 1 row of panels, you should use VirtualMatrixPanel which I guess that could handle also the original use case of 64x64 panels even though is not strictly needed.
I need to test this in a single 64x64 panel since I don't have those (give it a go please @jnthas) but I think that it should work.
Added a setting section too to make this easily configurable
Apologies for the diff changes about format in
firmware/lib/cw-commons/CWWebServer.h, those were made automatically by my VSCode, I can revert those if requested